Increase Suggestion memory limit #958
Conversation
| @@ -28,7 +28,7 @@ const ( | |||
|
|
|||
| cpuLimit = "500m" | |||
| cpuRequest = "50m" | |||
| memLimit = "100Mi" | |||
| memLimit = "200Mi" | |||
There was a problem hiding this comment.
I'd like that we can add resource field in katib-config ConfigMap suggestion data to make suggestion resource configurable for each one
There was a problem hiding this comment.
Agree. If resource field is added in katib-config for any suggestion algoroithm, it will override the default settings.
There was a problem hiding this comment.
Ok, I will add these values to katib-config in this PR.
|
I changed Please take a look @hougangliu @johnugeorge |
|
By this way, we can add more suggestion parameters to the configMap and then parse it in |
| @@ -34,6 +34,7 @@ data: | |||
| "image": "gcr.io/kubeflow-images-public/katib/v1alpha3/suggestion-hyperopt" | |||
| }, | |||
| "nasrl": { | |||
| "image": "gcr.io/kubeflow-images-public/katib/v1alpha3/suggestion-nasrl" | |||
| "image": "gcr.io/kubeflow-images-public/katib/v1alpha3/suggestion-nasrl", | |||
| "memLimit": "200Mi" | |||
There was a problem hiding this comment.
I prefer that here keep same style as k8s resources structure like below
image: gcr.io/kubeflow-images-public/katib/v1alpha3/suggestion-nasrl
resources:
requests:
memory: "64Mi"
cpu: "250m"
limits:
memory: "128Mi"
cpu: "500m"
There was a problem hiding this comment.
I changed structure for configMap.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For NAS RL Suggestion we need at least 200Mi memory limit.
Suggestion fails with OOM error if we have 100Mi there.
/cc @johnugeorge @gaocegege @hougangliu
This change is